// SPDX-FileCopyrightText: 2019 Yury Gubich // SPDX-FileCopyrightText: 2020 Linus Jahn // // SPDX-License-Identifier: LGPL-2.1-or-later #include "QXmppClient.h" #include "QXmppDiscoveryManager.h" #include "QXmppHttpUploadIq.h" #include "QXmppHttpUploadManager.h" #include "QXmppTlsManager_p.h" #include "QXmppUploadRequestManager.h" #include "IntegrationTesting.h" #include "TestClient.h" #include "util.h" #include static const auto UPLOAD_SERVICE_NAME = QStringLiteral("upload.montague.tld"); constexpr quint64 MAX_FILE_SIZE = 500UL * 1024UL * 1024UL; static void addUploadService(QXmppClient &client) { QVERIFY(client.findExtension()); QVERIFY(client.findExtension()); QByteArray xml = "" "" "" "" "" "" "urn:xmpp:http:upload:0" "" "" "" + QByteArray::number(MAX_FILE_SIZE) + "" "" "" "" ""; auto *discovery = client.findExtension(); QVERIFY(discovery->handleStanza(xmlToDom(xml))); } class tst_QXmppHttpUploadManager : public QObject { Q_OBJECT private: // UploadRequestManager Q_SLOT void testDiscoveryService_data(); Q_SLOT void testDiscoveryService(); Q_SLOT void testHandleStanza_data(); Q_SLOT void testHandleStanza(); Q_SLOT void testSending_data(); Q_SLOT void testSending(); Q_SLOT void testSendingFuture_data(); Q_SLOT void testSendingFuture(); Q_SLOT void testUploadService(); // HttpUploadManager Q_SLOT void testUpload(); }; void tst_QXmppHttpUploadManager::testHandleStanza_data() { QTest::addColumn("xml"); QTest::addColumn("accepted"); QTest::addColumn("event"); QTest::addColumn("error"); QTest::newRow("notAccepted") << QByteArray("" "" "" "" "What man art thou that, thus bescreen'd in night, so stumblest on my counsel?" "0e3141cd80894871a68e6fe6b1ec56fa" "" "" "" "") << false << false << false; QTest::newRow("slotReceived") << QByteArray("" "" "" "

Basic Base64String==

" "

foo=bar; user=romeo

" "" "" "" "") << true << true << false; QTest::newRow("tooLargeError") << QByteArray("" "" "" "" "File too large. The maximum file size is 20000 bytes" "" "20000" "" "" "") << true << true << true; QTest::newRow("quotaReachedError") << QByteArray("" "" "" "" "Quota reached. You can only upload 5 files in 5 minutes" "" "" "") << true << true << true; } void tst_QXmppHttpUploadManager::testHandleStanza() { QFETCH(QByteArray, xml); QFETCH(bool, accepted); QFETCH(bool, event); QFETCH(bool, error); TestClient test; auto *manager = test.addNewExtension(); bool eventReceived = false; bool errorReceived = false; QObject context; connect(manager, &QXmppUploadRequestManager::slotReceived, &context, [&](const auto &) { eventReceived = true; errorReceived = false; }); connect(manager, &QXmppUploadRequestManager::requestFailed, &context, [&](const auto &) { eventReceived = true; errorReceived = true; }); bool realAccepted = manager->handleStanza(xmlToDom(xml)); QCOMPARE(realAccepted, accepted); QCOMPARE(eventReceived, event); QCOMPARE(errorReceived, error); } void tst_QXmppHttpUploadManager::testDiscoveryService_data() { QTest::addColumn("xml"); QTest::addColumn("discovered"); QTest::newRow("mixDiscoveryStanzaIq") << QByteArray("" "" "" "" "" "" "") << false; QTest::newRow("HTTPUploadDiscoveryStanzaIq") << "" "" "" "" "" "" "urn:xmpp:http:upload:0" "" "" "" + QByteArray::number(MAX_FILE_SIZE) + "" "" "" "" "" << true; } void tst_QXmppHttpUploadManager::testDiscoveryService() { QFETCH(QByteArray, xml); QFETCH(bool, discovered); TestClient test; auto *discovery = test.addNewExtension(); auto *manager = test.addNewExtension(); bool accepted = discovery->handleStanza(xmlToDom(xml)); QCOMPARE(accepted, true); QCOMPARE(manager->serviceFound(), discovered); if (manager->serviceFound()) { QCOMPARE(manager->uploadServices().at(0).jid(), UPLOAD_SERVICE_NAME); QCOMPARE(manager->uploadServices().at(0).sizeLimit(), qint64(MAX_FILE_SIZE)); } } void tst_QXmppHttpUploadManager::testSending_data() { QTest::addColumn("fileInfo"); QTest::addColumn("fileName"); QTest::addColumn("fileSize"); QTest::addColumn("fileType"); QTest::newRow("fileInfo") << QFileInfo(":/test.svg") << "test.svg" << 2280LL << "image/svg+xml"; QTest::newRow("fileWithSizeBelowLimit") << QFileInfo() << "whatever.jpeg" << 698547LL << "image/jpeg"; QTest::newRow("fileWithSizeAboveLimit") << QFileInfo() << "some.pdf" << 65896498547LL << "application/pdf"; // there is no size above limit handling in request manager // there is also no code that selects an upload service with proper // size limit above requesting file size. // Is it something to worry about? } void tst_QXmppHttpUploadManager::testSending() { QFETCH(QFileInfo, fileInfo); QFETCH(QString, fileName); QFETCH(qint64, fileSize); QFETCH(QString, fileType); auto expectedMimeType = QMimeDatabase().mimeTypeForName(fileType); TestClient test; test.addNewExtension(); auto *manager = test.addNewExtension(); addUploadService(test); QString returnId; if (!fileInfo.baseName().isEmpty()) { returnId = manager->requestUploadSlot(fileInfo); } else { returnId = manager->requestUploadSlot(fileName, fileSize, expectedMimeType); } QXmppHttpUploadRequestIq iq; parsePacket(iq, test.takePacket().toUtf8()); QCOMPARE(iq.type(), QXmppIq::Get); QCOMPARE(iq.to(), UPLOAD_SERVICE_NAME); QCOMPARE(iq.fileName(), fileName); QCOMPARE(iq.size(), fileSize); QCOMPARE(iq.contentType(), expectedMimeType); // The client is not connected, so we never get an ID back (the packet was not sent). QVERIFY(returnId.isNull()); } void tst_QXmppHttpUploadManager::testSendingFuture_data() { testSending_data(); } void tst_QXmppHttpUploadManager::testSendingFuture() { QFETCH(QFileInfo, fileInfo); QFETCH(QString, fileName); QFETCH(qint64, fileSize); QFETCH(QString, fileType); auto expectedMimeType = QMimeDatabase().mimeTypeForName(fileType); TestClient test; test.addNewExtension(); auto *manager = test.addNewExtension(); addUploadService(test); auto future = [=]() { if (!fileInfo.baseName().isEmpty()) { return manager->requestSlot(fileInfo); } else { return manager->requestSlot(fileName, fileSize, expectedMimeType); } }(); QVERIFY(!future.isFinished()); // check sent packet QXmppHttpUploadRequestIq iq; parsePacket(iq, test.takePacket().toUtf8()); QCOMPARE(iq.type(), QXmppIq::Get); QCOMPARE(iq.to(), UPLOAD_SERVICE_NAME); QCOMPARE(iq.fileName(), fileName); QCOMPARE(iq.size(), fileSize); QCOMPARE(iq.contentType(), expectedMimeType); // inject reply QByteArray reply = "" "" "" "

Basic Base64String==

" "

application/json

" "

foo=bar; user=romeo

" "" "" "" ""; test.inject(reply); auto slot = expectFutureVariant(future); QCOMPARE(slot.getUrl(), QUrl("https://download.montague.tld/4a771ac1-f0b2-4a4a-9700-f2a26fa2bb67/tr%C3%A8s%20cool.jpg")); QCOMPARE(slot.putUrl(), QUrl("https://upload.montague.tld/4a771ac1-f0b2-4a4a-9700-f2a26fa2bb67/tr%C3%A8s%20cool.jpg")); // checks that the disallowed 'Content-type' header is not set QCOMPARE(slot.putHeaders().size(), 2); QCOMPARE(slot.putHeaders().keys()[0], QStringLiteral("Authorization")); QCOMPARE(slot.putHeaders().keys()[1], QStringLiteral("Cookie")); } void tst_QXmppHttpUploadManager::testUploadService() { QXmppUploadService service; QCOMPARE(service.sizeLimit(), -1LL); QVERIFY(service.jid().isNull()); service.setSizeLimit(256LL * 1024LL * 1024LL); QCOMPARE(service.sizeLimit(), 256LL * 1024LL * 1024LL); service.setJid(QStringLiteral("upload.shakespeare.lit")); QCOMPARE(service.jid(), QStringLiteral("upload.shakespeare.lit")); } void tst_QXmppHttpUploadManager::testUpload() { using DiscoInfoResult = QXmppDiscoveryManager::InfoResult; using DiscoItem = QXmppDiscoveryIq::Item; SKIP_IF_INTEGRATION_TESTS_DISABLED() TestClient test; test.addNewExtension(); auto *disco = test.addNewExtension(); test.addNewExtension(); auto *uploadManager = test.addNewExtension(); test.connectToServer(IntegrationTests::clientConfiguration()); QSignalSpy(&test, &QXmppClient::connected).wait(); QVERIFY(test.isConnected()); // get server items auto items = expectVariant>(wait(disco->requestDiscoItems(test.configuration().domain()).toFuture(this))); // request disco info for each item std::vector> infoFutures; std::transform(items.cbegin(), items.cend(), std::back_inserter(infoFutures), [disco](const auto &item) { return disco->requestDiscoInfo(item.jid(), item.node()); }); auto uploadServiceJid = [&]() { for (auto &future : infoFutures) { auto result = expectVariant(wait(future.toFuture(this))); for (const auto &identity : result.identities()) { if (identity.category() == "store" && identity.type() == "file" && result.features().contains("urn:xmpp:http:upload:0")) { return result.from(); } } } return QString(); }(); // check whether the server supports HTTP File Upload if (uploadServiceJid.isEmpty()) { QSKIP("The server does not support HTTP File Upload."); } auto upload = uploadManager->uploadFile(QFileInfo(":/test.svg"), "test_renamed.png", uploadServiceJid); QVERIFY2(!upload->isFinished(), "Uploading resulted instantly in an error"); { // check sent request QXmppHttpUploadRequestIq iq; parsePacket(iq, test.takeLastPacket().toUtf8()); QCOMPARE(iq.contentType().name(), QStringLiteral("image/svg+xml")); QCOMPARE(iq.fileName(), QStringLiteral("test_renamed.png")); QCOMPARE(iq.size(), 2280LL); } // test signals QSignalSpy finishedSpy(upload.get(), &QXmppHttpUpload::finished); QSignalSpy progressSpy(upload.get(), &QXmppHttpUpload::progressChanged); finishedSpy.wait(); QCOMPARE(finishedSpy.size(), 1); QVERIFY(!progressSpy.empty()); // test result auto result = upload->result().value(); if (std::holds_alternative(result)) { qDebug() << "Upload failed:" << std::get(result).description; QVERIFY2(false, "Uploading the file failed"); } auto url = expectVariant(std::move(result)); QCOMPARE(upload->bytesSent(), 2280ULL); QCOMPARE(upload->bytesTotal(), 2280ULL); QCOMPARE(upload->progress(), 1.0); qDebug() << "Uploaded file to" << url.toDisplayString(); } QTEST_MAIN(tst_QXmppHttpUploadManager) #include "tst_qxmpphttpuploadmanager.moc"