From 0b616178800ccb4e5d344cd66b8f1ab9f5d3b698 Mon Sep 17 00:00:00 2001 From: Melvin Keskin Date: Mon, 24 Feb 2020 11:20:30 +0100 Subject: Fix switch statement when handling IQ stanza for registration --- .../tst_qxmppregistrationmanager.cpp | 24 ++++++++++++---------- 1 file changed, 13 insertions(+), 11 deletions(-) (limited to 'tests') diff --git a/tests/qxmppregistrationmanager/tst_qxmppregistrationmanager.cpp b/tests/qxmppregistrationmanager/tst_qxmppregistrationmanager.cpp index 077b65d4..15ecde95 100644 --- a/tests/qxmppregistrationmanager/tst_qxmppregistrationmanager.cpp +++ b/tests/qxmppregistrationmanager/tst_qxmppregistrationmanager.cpp @@ -350,17 +350,17 @@ void tst_QXmppRegistrationManager::testRegistrationResult() registrationRequestForm.setEmail(QStringLiteral("1234@example.org")); registrationRequestForm.setId(QStringLiteral("register1")); - bool signalCalled = false; + bool succeededSignalCalled = false; + bool failedSignalCalled = false; + QObject *context = new QObject(this); - if (isSuccess) { - connect(manager, &QXmppRegistrationManager::registrationSucceeded, context, [&]() { - signalCalled = true; - }); - } else { - connect(manager, &QXmppRegistrationManager::registrationFailed, context, [&](const QXmppStanza::Error &) { - signalCalled = true; - }); - } + + connect(manager, &QXmppRegistrationManager::registrationSucceeded, context, [&]() { + succeededSignalCalled = true; + }); + connect(manager, &QXmppRegistrationManager::registrationFailed, context, [&](const QXmppStanza::Error &) { + failedSignalCalled = true; + }); manager->setRegistrationFormToSend(registrationRequestForm); manager->sendCachedRegistrationForm(); @@ -370,7 +370,9 @@ void tst_QXmppRegistrationManager::testRegistrationResult() manager->handleStanza(writePacketToDom(serverResult)); - QVERIFY(signalCalled); + QCOMPARE(succeededSignalCalled, isSuccess); + QCOMPARE(failedSignalCalled, !isSuccess); + delete context; } -- cgit v1.2.3