From bf078ff6342b052e36995defcf641edea6bb2b8c Mon Sep 17 00:00:00 2001
From: Linus Jahn <lnj@kaidan.im>
Date: Sat, 31 Dec 2022 23:29:59 +0100
Subject: OmemoManager: Replace multi-result futures with single result futures

QXmppTask won't support multi-result and in the case of the OmemoManager
it's not really needed. If you want to know when each single request is
finished you can just subscribe/unsubscribe from each jid in a single
request.

Part of #502.
---
 src/omemo/QXmppOmemoManager_p.cpp | 38 +++++++++++++++++++++-----------------
 1 file changed, 21 insertions(+), 17 deletions(-)

(limited to 'src/omemo/QXmppOmemoManager_p.cpp')

diff --git a/src/omemo/QXmppOmemoManager_p.cpp b/src/omemo/QXmppOmemoManager_p.cpp
index 01981fad..722211a8 100644
--- a/src/omemo/QXmppOmemoManager_p.cpp
+++ b/src/omemo/QXmppOmemoManager_p.cpp
@@ -3154,32 +3154,36 @@ QFuture<QXmppPubSubManager::Result> ManagerPrivate::subscribeToDeviceList(const
 //
 // \return the results of each unsubscribe request
 //
-QFuture<Manager::DevicesResult> ManagerPrivate::unsubscribeFromDeviceLists(const QList<QString> &jids)
+QFuture<QVector<Manager::DevicesResult>> ManagerPrivate::unsubscribeFromDeviceLists(const QList<QString> &jids)
 {
-    QFutureInterface<Manager::DevicesResult> interface = (QFutureInterfaceBase::Started);
+    if (jids.isEmpty()) {
+        return makeReadyFuture(QVector<Manager::DevicesResult>());
+    }
 
-    const auto jidsCount = jids.size();
-    auto processedJidsCount = std::make_shared<int>(0);
+    struct State {
+        int processed = 0;
+        int jidsCount = 0;
+        QFutureInterface<QVector<Manager::DevicesResult>> interface;
+        QVector<Manager::DevicesResult> devicesResults;
+    };
 
-    if (jidsCount == 0) {
-        interface.reportFinished();
-    }
+    auto state = std::make_shared<State>();
+    state->jidsCount = jids.count();
 
     for (const auto &jid : jids) {
-        auto future = unsubscribeFromDeviceList(jid);
-        await(future, q, [=](QXmppPubSubManager::Result result) mutable {
-            Manager::DevicesResult devicesResult;
-            devicesResult.jid = jid;
-            devicesResult.result = result;
-            interface.reportResult(devicesResult);
-
-            if (++(*processedJidsCount) == jidsCount) {
-                interface.reportFinished();
+        await(unsubscribeFromDeviceList(jid), q, [jid, state](QXmppPubSubManager::Result result) mutable {
+            state->devicesResults << Manager::DevicesResult {
+                jid, result
+            };
+
+            if (++(state->processed) == state->jidsCount) {
+                state->interface.reportResult(state->devicesResults);
+                state->interface.reportFinished();
             }
         });
     }
 
-    return interface.future();
+    return state->interface.future();
 }
 
 //
-- 
cgit v1.2.3