From 8367c295fbaef907daa67a6173c228c80b7b974b Mon Sep 17 00:00:00 2001 From: Jan Lorenz Date: Fri, 11 Dec 2020 17:58:17 +0100 Subject: QXmppTransferManager: Fix undefined behaviour when parsing features (#322) Co-authored-by: Jan Lorenz --- src/client/QXmppTransferManager.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'src/client/QXmppTransferManager.cpp') diff --git a/src/client/QXmppTransferManager.cpp b/src/client/QXmppTransferManager.cpp index 098e8d6b..b68ab595 100644 --- a/src/client/QXmppTransferManager.cpp +++ b/src/client/QXmppTransferManager.cpp @@ -1342,7 +1342,9 @@ void QXmppTransferManager::streamInitiationResultReceived(const QXmppStreamIniti job->state() != QXmppTransferJob::OfferState) return; - const auto &fields = iq.featureForm().fields(); + const auto &form = iq.featureForm(); + const auto &fields = form.fields(); + for (const auto &field : fields) { if (field.key() == "stream-method") { if ((field.value().toString() == ns_ibb) && @@ -1423,7 +1425,9 @@ void QXmppTransferManager::streamInitiationSetReceived(const QXmppStreamInitiati job->d->sid = iq.siId(); job->d->mimeType = iq.mimeType(); job->d->fileInfo = iq.fileInfo(); - const auto &fields = iq.featureForm().fields(); + + const auto &form = iq.featureForm(); + const auto &fields = form.fields(); for (const auto &field : fields) { if (field.key() == "stream-method") { QPair option; -- cgit v1.2.3