From 1655bced3931d269654734db261412330f91a242 Mon Sep 17 00:00:00 2001
From: Linus Jahn <lnj@kaidan.im>
Date: Wed, 28 Dec 2022 19:46:37 +0100
Subject: ClientExtension: Save d-ptr allocation

The d-ptr only contained one other pointer which can be stored directly.
If we should need another attribute, we can just re-add the d-ptr since
it has the same size as the current QXmppClient ptr.

Closes #522.
---
 src/client/QXmppClientExtension.cpp | 24 ++++++++----------------
 1 file changed, 8 insertions(+), 16 deletions(-)

(limited to 'src/client/QXmppClientExtension.cpp')

diff --git a/src/client/QXmppClientExtension.cpp b/src/client/QXmppClientExtension.cpp
index a6fadb4b..131af7c3 100644
--- a/src/client/QXmppClientExtension.cpp
+++ b/src/client/QXmppClientExtension.cpp
@@ -6,36 +6,27 @@
 
 #include "QXmppClient.h"
 
-#include <QStringList>
-
-class QXmppClientExtensionPrivate
-{
-public:
-    QXmppClient *client;
-};
-
 ///
 /// Constructs a QXmppClient extension.
 ///
 QXmppClientExtension::QXmppClientExtension()
-    : d(new QXmppClientExtensionPrivate)
+    : m_client(nullptr)
 {
-    d->client = nullptr;
 }
 
 QXmppClientExtension::~QXmppClientExtension() = default;
 
+///
 /// Returns the discovery features to add to the client.
 ///
-
 QStringList QXmppClientExtension::discoveryFeatures() const
 {
     return QStringList();
 }
 
+///
 /// Returns the discovery identities to add to the client.
 ///
-
 QList<QXmppDiscoveryIq::Identity> QXmppClientExtension::discoveryIdentities() const
 {
     return QList<QXmppDiscoveryIq::Identity>();
@@ -81,21 +72,22 @@ bool QXmppClientExtension::handleStanza(const QDomElement &, const std::optional
     return false;
 }
 
+///
 /// Returns the client which loaded this extension.
 ///
-
 QXmppClient *QXmppClientExtension::client()
 {
-    return d->client;
+    return m_client;
 }
 
+///
 /// Sets the client which loaded this extension.
 ///
 /// \param client
-
+///
 void QXmppClientExtension::setClient(QXmppClient *client)
 {
-    d->client = client;
+    m_client = client;
 }
 
 ///
-- 
cgit v1.2.3