From a811aeb01bb0af1197434f73f6f1136e9cdc4873 Mon Sep 17 00:00:00 2001 From: Linus Jahn Date: Tue, 14 Mar 2023 23:28:54 +0100 Subject: CarbonManagerV2: Don't set 'to' address of carbon enable IQ RFC6120 says we MUST NOT set a to address for such stanzas. From section 8.1.1.1.: 2. A stanza sent from a client to a server for direct processing by the server (e.g., roster processing as described in [XMPP-IM] or presence sent to the server for broadcasting to other entities) MUST NOT possess a 'to' attribute. --- src/client/QXmppCarbonManagerV2.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/client/QXmppCarbonManagerV2.cpp') diff --git a/src/client/QXmppCarbonManagerV2.cpp b/src/client/QXmppCarbonManagerV2.cpp index 7959cab3..97831731 100644 --- a/src/client/QXmppCarbonManagerV2.cpp +++ b/src/client/QXmppCarbonManagerV2.cpp @@ -18,10 +18,9 @@ using namespace QXmpp::Private; class CarbonEnableIq : public QXmppIq { public: - CarbonEnableIq(const QString &jid) + CarbonEnableIq() : QXmppIq() { - setTo(jid); setType(QXmppIq::Set); } @@ -165,7 +164,7 @@ void QXmppCarbonManagerV2::enableCarbons() return; } - client()->sendIq(CarbonEnableIq(client()->configuration().jidBare())).then(this, [this](QXmppClient::IqResult domResult) { + client()->sendIq(CarbonEnableIq()).then(this, [this](QXmppClient::IqResult domResult) { if (auto err = parseIq(std::move(domResult))) { warning("Could not enable message carbons: " % err->description); } else { -- cgit v1.2.3