From 8cf1dc8a0eb6b399fc6676b0a2a82aef3af1b22c Mon Sep 17 00:00:00 2001
From: Linus Jahn <lnj@kaidan.im>
Date: Sun, 13 Mar 2022 01:15:33 +0100
Subject: Split with char instead of string when possible

Saves constructing the QString and makes the splitting faster.
---
 src/base/QXmppJingleIq.cpp | 2 +-
 src/base/QXmppSasl.cpp     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/base')

diff --git a/src/base/QXmppJingleIq.cpp b/src/base/QXmppJingleIq.cpp
index 1adf3daa..072e1e97 100644
--- a/src/base/QXmppJingleIq.cpp
+++ b/src/base/QXmppJingleIq.cpp
@@ -461,7 +461,7 @@ void QXmppJingleIq::Content::toXml(QXmlStreamWriter *writer) const
 bool QXmppJingleIq::Content::parseSdp(const QString &sdp)
 {
     QList<QXmppJinglePayloadType> payloads;
-    for (auto &line : sdp.split('\n')) {
+    for (auto &line : sdp.split(QChar(u'\n'))) {
         if (line.endsWith('\r'))
             line.resize(line.size() - 1);
         if (line.startsWith(QStringLiteral("a="))) {
diff --git a/src/base/QXmppSasl.cpp b/src/base/QXmppSasl.cpp
index 317765aa..74d67593 100644
--- a/src/base/QXmppSasl.cpp
+++ b/src/base/QXmppSasl.cpp
@@ -936,8 +936,8 @@ QByteArray QXmppSaslDigestMd5::serializeMessage(const QMap<QByteArray, QByteArra
             }
         }
         if (quote) {
-            value.replace(QByteArrayLiteral("\\"), QByteArrayLiteral("\\\\"));
-            value.replace(QByteArrayLiteral("\""), QByteArrayLiteral("\\\""));
+            value.replace('\\', QByteArrayLiteral("\\\\"));
+            value.replace('\"', QByteArrayLiteral("\\\""));
             ba.append('"' + value + '"');
         } else {
             ba.append(value);
-- 
cgit v1.2.3