From 5845b4b4c481f00e33e9d526b8538e4c20f92d8c Mon Sep 17 00:00:00 2001 From: Linus Jahn Date: Sun, 13 Mar 2022 01:16:37 +0100 Subject: JingleIq: Reuse QRegularExpression It's thread_local because QRegularExpression is not thread-safe. --- src/base/QXmppJingleIq.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/base') diff --git a/src/base/QXmppJingleIq.cpp b/src/base/QXmppJingleIq.cpp index 072e1e97..d039dd5c 100644 --- a/src/base/QXmppJingleIq.cpp +++ b/src/base/QXmppJingleIq.cpp @@ -496,7 +496,9 @@ bool QXmppJingleIq::Content::parseSdp(const QString &sdp) if (payload.name() == QStringLiteral("telephone-event")) { params.insert(QStringLiteral("events"), paramStr); } else { - for (const auto &p : paramStr.split(QRegularExpression(";\\s*"))) { + thread_local static const auto regex = QRegularExpression(";\\s*"); + const auto paramParts = paramStr.split(regex); + for (const auto &p : paramParts) { const QStringList bits = p.split('='); if (bits.size() == 2) params.insert(bits.at(0), bits.at(1)); -- cgit v1.2.3