From 05e418edc732b63048db65a715238c602f8e8524 Mon Sep 17 00:00:00 2001
From: Jeremy Lainé <jeremy.laine@m4x.org>
Date: Mon, 9 Aug 2010 15:07:35 +0000
Subject: tighten XML RPC parsing

---
 source/xmlrpc.cpp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

(limited to 'source/xmlrpc.cpp')

diff --git a/source/xmlrpc.cpp b/source/xmlrpc.cpp
index 3db63f0d..55008731 100644
--- a/source/xmlrpc.cpp
+++ b/source/xmlrpc.cpp
@@ -181,14 +181,14 @@ bool XMLRPC::RequestMessage::parse(const QDomElement &element)
     const QDomElement methodParams = element.firstChildElement("params");
     if( !methodParams.isNull() )
     {
-        QDomNode param = methodParams.firstChild();
+        QDomNode param = methodParams.firstChildElement("param");
         while (!param.isNull())
         {
             QVariant arg = demarshall(param.firstChild().toElement(), errors);
             if (!errors.isEmpty())
                 return false;
             m_args << arg;
-            param = param.nextSibling();
+            param = param.nextSiblingElement("param");
         }
     }
     return true;
@@ -238,20 +238,20 @@ bool XMLRPC::ResponseMessage::parse(const QDomElement &element)
     const QDomElement contents = element.firstChild().toElement();
     if( contents.tagName().toLower() == "params")
     {
-        QDomNode param = contents.firstChild();
+        QDomNode param = contents.firstChildElement("param");
         while (!param.isNull())
         {
-            const QVariant value = demarshall(param.firstChild().toElement(), errors);
+            const QVariant value = demarshall(param.firstChildElement(), errors);
             if (!errors.isEmpty())
                 return false;
             m_values << value;
-            param = param.nextSibling();
+            param = param.nextSiblingElement("param");
         }
         return true;
     }
     else if( contents.tagName().toLower() == "fault")
     {
-        const QDomElement errElement = contents.firstChild().toElement();
+        const QDomElement errElement = contents.firstChildElement();
         const QVariant error = demarshall(errElement, errors);
 
         qWarning() << QString("XMLRPC Fault %1: %2")
-- 
cgit v1.2.3