ICE: sort candidate pairs according RFC 5245

1 files changed, 10 insertions, 0 deletions

diff --git a/src/base/QXmppStun.cpp b/src/base/QXmppStun.cpp
index 5c0d8e85..f6dd84c8 100644
--- a/src/base/QXmppStun.cpp
+++ b/src/base/QXmppStun.cpp
@@ -1550,6 +1550,11 @@ private:
     bool m_controlling;
 };
 
+static bool candidatePairPtrLessThan(const CandidatePair *p1, const CandidatePair *p2)
+{
+    return p1->priority() < p2->priority();
+}
+
 CandidatePair::CandidatePair(int component, bool controlling)
     : checked(QIODevice::NotOpen),
     socket(0),
@@ -1828,6 +1833,9 @@ bool QXmppIceComponent::addRemoteCandidate(const QXmppJingleCandidate &candidate
         pair->socket = 0;
         m_pairs << pair;
     }
+
+    qSort(m_pairs.begin(), m_pairs.end(), candidatePairPtrLessThan);
+
     return true;
 }
 
@@ -1855,6 +1863,8 @@ CandidatePair *QXmppIceComponent::addRemoteCandidate(QUdpSocket *socket, const Q
     pair->socket = socket;
     m_pairs << pair;
 
+    qSort(m_pairs.begin(), m_pairs.end(), candidatePairPtrLessThan);
+
     debug(QString("Added candidate %1").arg(pair->toString()));
     return pair;
 }