Fix a bug in OS X 32-bit code.

Get rid of an unused ivar, as pointed out by Clang.
Adding a comment about a false positive in Clang's static analyzer.

git-svn-id: https://pcsxr.svn.codeplex.com/svn/pcsxr@85933 e17a0e51-4ae3-4d35-97c3-1a29b211df97

macosx/ConfigurationController.h

@@ -48,7 +48,7 @@ extern NSString *const memCardChangeNumberKey;
 - (IBAction)setVideoType:(id)sender;
 
 - (NSString *)keyForSender:(id)sender;
-+ (void)setMemoryCard:(int)theCard toPath:(NSString *)theFile DEPRECATED_ATTRIBUTE;
++ (void)setMemoryCard:(int)theCard toPath:(NSString *)theFile;
 + (void)setMemoryCard:(int)theCard toURL:(NSURL *)theURL;
 
 + (void)mcdNewClicked:(id)sender;

macosx/LaunchArg.m

@@ -27,7 +27,7 @@
 	if (_theBlock == theBlock) {
 		return;
 	}
-	dispatch_block_t tmpBlock = _theBlock
+	dispatch_block_t tmpBlock = _theBlock;
 	_theBlock = [theBlock copy];
 	[tmpBlock release];
 #endif

macosx/PcsxrMemCardArray.h

@@ -14,7 +14,6 @@
 	@private
 	NSArray *rawArray;
 	int cardNumber;
-	NSURL *fileURL;
 }
 
 - (id)initWithMemoryCardNumber:(int)carNum;

macosx/PluginList.m

@@ -235,6 +235,7 @@ const static int typeList[] = {PSE_LT_GPU, PSE_LT_SPU, PSE_LT_CDR, PSE_LT_PAD, P
 	// stop the old plugin and start the new one
 	if (pluginPtr) {
 		[pluginPtr shutdownAs:type];
+		//NOTE: We can ignore Clang's "Incorrect Decrement" here
 		RELEASEOBJ(pluginPtr);
 	}