diff options
| author | Xavier Del Campo Romero <xavi.dcr@tutanota.com> | 2023-03-20 03:32:00 +0100 |
|---|---|---|
| committer | Xavier Del Campo Romero <xavi.dcr@tutanota.com> | 2023-07-20 23:52:53 +0200 |
| commit | 483169d192c1efd35c4428eec4dddefb5b5aa59f (patch) | |
| tree | c0a74c80698b425587f72d28e9552188f8de1040 | |
| parent | fdf6dc246460504ce3ead44f79f4df0ab5edd918 (diff) | |
Send response on quota exceeded
So far, slcl would just close the connection with a client when the
Content-Length of an incoming request exceeded the user quota, without
any meaningful information given back to the user.
Now, slcl responds with a HTML file with meaningful information about
the error.
Limitations:
- While this commits has been successfully tested on ungoogled-chromium,
LibreWolf (and I assume Firefox and any other derivates too) does not
seem to receive the response from the server.
- However, this issue only occurred during local testing, but not
on remote instances.
| -rw-r--r-- | handler.c | 5 | ||||
| -rw-r--r-- | handler.h | 2 | ||||
| -rw-r--r-- | http.c | 33 | ||||
| -rw-r--r-- | http.h | 3 |
4 files changed, 32 insertions, 11 deletions
@@ -112,13 +112,14 @@ static int on_payload(const struct http_payload *const p, } static int on_length(const unsigned long long len, - const struct http_cookie *const c, void *const user) + const struct http_cookie *const c, struct http_response *const r, + void *const user) { struct client *const cl = user; struct handler *const h = cl->h; if (h->cfg.length) - return h->cfg.length(len, c, h->cfg.user); + return h->cfg.length(len, c, r, h->cfg.user); return 0; } @@ -11,7 +11,7 @@ struct handler_cfg { const char *tmpdir; int (*length)(unsigned long long len, const struct http_cookie *c, - void *user); + struct http_response *r, void *user); void *user; }; @@ -85,7 +85,7 @@ struct http_ctx struct write_ctx { - bool pending; + bool pending, close; enum state state; struct http_response r; off_t n; @@ -372,6 +372,8 @@ static int write_header_cr_line(struct http_ctx *const h, bool *const close) return rw_error(res, close); else if ((w->n += res) >= d->len) { + const bool close_pending = w->close; + dynstr_free(d); if (w->r.n) @@ -384,6 +386,8 @@ static int write_header_cr_line(struct http_ctx *const h, bool *const close) fprintf(stderr, "%s: write_ctx_free failed\n", __func__); return -1; } + else if (close_pending) + *close = true; } return 0; @@ -394,17 +398,24 @@ static int write_body_mem(struct http_ctx *const h, bool *const close) struct write_ctx *const w = &h->wctx; const struct http_response *const r = &w->r; const size_t rem = r->n - w->n; - const int res = h->cfg.write((const char *)r->buf.ro + w->n, rem, + int res = h->cfg.write((const char *)r->buf.ro + w->n, rem, h->cfg.user); if (res <= 0) return rw_error(res, close); else if ((w->n += res) >= r->n) { + const bool close_pending = w->close; + if (h->version == HTTP_1_0) *close = true; - return write_ctx_free(w); + if ((res = write_ctx_free(w))) + fprintf(stderr, "%s: write_ctx_free failed\n", __func__); + else if (close_pending) + *close = true; + + return res; } return 0; @@ -425,16 +436,21 @@ static int write_body_file(struct http_ctx *const h, bool *const close) return -1; } - const int res = h->cfg.write(buf, rem, h->cfg.user); + int res = h->cfg.write(buf, rem, h->cfg.user); if (res <= 0) return rw_error(res, close); else if ((w->n += res) >= r->n) { + const bool close_pending = w->close; + if (h->version == HTTP_1_0) *close = true; - return write_ctx_free(w); + if ((res = write_ctx_free(w))) + fprintf(stderr, "%s: write_ctx_free failed\n", __func__); + else if (close_pending) + *close = true; } return 0; @@ -810,7 +826,7 @@ static int check_length(struct http_ctx *const h) .value = c->value }; - return h->cfg.length(c->post.len, &cookie, h->cfg.user); + return h->cfg.length(c->post.len, &cookie, &h->wctx.r, h->cfg.user); } static int header_cr_line(struct http_ctx *const h) @@ -834,7 +850,10 @@ static int header_cr_line(struct http_ctx *const h) const int res = check_length(h); if (res) - return res; + { + h->wctx.close = true; + return start_response(h); + } } c->state = BODY_LINE; @@ -45,6 +45,7 @@ struct http_payload X(UNAUTHORIZED, "Unauthorized", 401) \ X(FORBIDDEN, "Forbidden", 403) \ X(NOT_FOUND, "Not found", 404) \ + X(PAYLOAD_TOO_LARGE, "Payload too large", 413) \ X(INTERNAL_ERROR, "Internal Server Error", 500) struct http_response @@ -80,7 +81,7 @@ struct http_cfg int (*payload)(const struct http_payload *p, struct http_response *r, void *user); int (*length)(unsigned long long len, const struct http_cookie *c, - void *user); + struct http_response *r, void *user); const char *tmpdir; void *user; }; |
