Use const variables

src/dialogs/certificateiodialog.cpp

@@ -72,7 +72,7 @@ void CertificateIoDialog::on_select_certificate_file_button_clicked()
     if(dialog.exec() != QDialog::Accepted)
         return;
 
-    this->ui->certificate_file_name->setText(dialog.selectedFiles().first());
+    this->ui->certificate_file_name->setText(dialog.selectedFiles().constFirst());
 
     this->updateUI();
 }
@@ -88,7 +88,7 @@ void CertificateIoDialog::on_select_key_file_button_clicked()
     if(dialog.exec() != QDialog::Accepted)
         return;
 
-    this->ui->key_file_name->setText(dialog.selectedFiles().first());
+    this->ui->key_file_name->setText(dialog.selectedFiles().constFirst());
 
     this->updateUI();
 }

src/dialogs/newidentitiydialog.cpp

@@ -19,7 +19,7 @@ NewIdentitiyDialog::NewIdentitiyDialog(QWidget *parent) :
     ui->expiration_date->setTime(QTime(12, 00));
 
     ui->group->clear();
-    for(auto group_name : kristall::identities.groups())
+    for(const auto &group_name : kristall::identities.groups())
     {
         ui->group->addItem(group_name);
     }

src/identitycollection.cpp

@@ -106,7 +106,7 @@ void IdentityCollection::load(QSettings &settings)
             id->identity.certificate = QSslCertificate::fromData(
                 settings.value("certificate").toByteArray(),
                 QSsl::Der
-            ).first();
+            ).constFirst();
 
             id->identity.private_key = QSslKey(
                 settings.value("private_key").toByteArray(),

src/main.cpp

@@ -272,7 +272,7 @@ int main(int argc, char *argv[])
 
     auto urls = cli_parser.positionalArguments();
     if(urls.size() > 0) {
-        for(auto url_str : urls) {
+        for(const auto &url_str : urls) {
             QUrl url { url_str };
             if (url.isRelative()) {
                 if (QFile::exists(url_str)) {

src/trustedhostcollection.cpp

@@ -104,7 +104,7 @@ void TrustedHostCollection::clear()
 
 bool TrustedHostCollection::insert(const TrustedHost &host)
 {
-    for(auto const & item : items)
+    for(auto const & item : qAsConst(items))
     {
         if(item.host_name == host.host_name)
             return false;