From 40d23d4220b114d8a71ddd1d883ca4289e7f0abd Mon Sep 17 00:00:00 2001 From: Amey Telawane Date: Mon, 1 Aug 2016 16:50:43 +0530 Subject: BACKPORT: trace: resolve stack corruption due to string copy Strcpy has no limit on string being copied which causes stack corruption leading to kernel panic. Use strlcpy to resolve the issue by providing length of string to be copied. CRs-fixed: 1048480 Bug: 35399704 Change-Id: Ib290b25f7e0ff96927b8530e5c078869441d409f Signed-off-by: Amey Telawane --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'kernel/trace') diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 55d214c60..5298609f7 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -1549,7 +1549,7 @@ void trace_find_cmdline(int pid, char comm[]) arch_spin_lock(&trace_cmdline_lock); map = map_pid_to_cmdline[pid]; if (map != NO_CMDLINE_MAP) - strcpy(comm, saved_cmdlines[map]); + strlcpy(comm, saved_cmdlines[map], TASK_COMM_LEN); else strcpy(comm, "<...>"); -- cgit v1.2.3