From 40dacaaf5628101771dc5bd45bc47bd0ea7842e5 Mon Sep 17 00:00:00 2001 From: Nathan Chancellor Date: Thu, 26 Jan 2017 15:22:46 -0700 Subject: fs: namespace: fix maybe-uninitialized warning fs/namespace.c: In function 'SyS_mount': fs/namespace.c:2617:8: warning: 'kernel_dev' may be used uninitialized in this function [-Wmaybe-uninitialized] ret = do_mount(kernel_dev, kernel_dir->name, kernel_type, flags, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (void *) data_page); ~~~~~~~~~~~~~~~~~~~ fs/namespace.c:2596:8: note: 'kernel_dev' was declared here char *kernel_dev; ^~~~~~~~~~ fs/namespace.c:2617:8: warning: 'kernel_type' may be used uninitialized in this function [-Wmaybe-uninitialized] ret = do_mount(kernel_dev, kernel_dir->name, kernel_type, flags, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (void *) data_page); ~~~~~~~~~~~~~~~~~~~ fs/namespace.c:2594:8: note: 'kernel_type' was declared here char *kernel_type; ^~~~~~~~~~~ Signed-off-by: Nathan Chancellor --- fs/namespace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'fs') diff --git a/fs/namespace.c b/fs/namespace.c index fb4dc34ef..e3842b535 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2749,9 +2749,9 @@ SYSCALL_DEFINE5(mount, char __user *, dev_name, char __user *, dir_name, char __user *, type, unsigned long, flags, void __user *, data) { int ret; - char *kernel_type; + char *kernel_type = NULL; struct filename *kernel_dir; - char *kernel_dev; + char *kernel_dev = NULL; unsigned long data_page; ret = copy_mount_string(type, &kernel_type); -- cgit v1.2.3